anmolbabu has uploaded a new change for review.
Change subject: webadmin : Hide cluster logical networks virt-related fields
in Gluster only mode
......................................................................
webadmin : Hide cluster logical networks virt-related fields
in Gluster only mode
Currently, the menu options like "Add Network", "Manage
Networks" and "Set as Display" and the dialogues coming from these
menu options, are confusing the end-user and they are getting a false
impression that some of these things can be configured, where as they
are not applicable to RHS.
Change-Id: I2436c11b51f6707c70aef426e1e253ff958fa6dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015020
Signed-off-by: Anmol Babu <[email protected]>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
1 file changed, 22 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/22189/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
index 6ae4d48..109d556 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
@@ -8,12 +8,14 @@
import org.ovirt.engine.core.common.businessentities.VDSGroup;
import org.ovirt.engine.core.common.businessentities.network.Network;
import org.ovirt.engine.core.common.businessentities.network.NetworkStatus;
+import org.ovirt.engine.core.common.mode.ApplicationMode;
import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
import org.ovirt.engine.ui.common.uicommon.model.SearchableDetailModelProvider;
import org.ovirt.engine.ui.common.widget.table.column.EnumColumn;
import
org.ovirt.engine.ui.common.widget.table.column.SafeHtmlWithSafeHtmlTooltipColumn;
import org.ovirt.engine.ui.common.widget.table.column.TextColumnWithTooltip;
import org.ovirt.engine.ui.uicommonweb.UICommand;
+import org.ovirt.engine.ui.uicommonweb.models.ApplicationModeHelper;
import org.ovirt.engine.ui.uicommonweb.models.clusters.ClusterListModel;
import org.ovirt.engine.ui.uicommonweb.models.clusters.ClusterNetworkListModel;
import org.ovirt.engine.ui.webadmin.ApplicationConstants;
@@ -133,26 +135,28 @@
};
getTable().addColumn(descColumn, constants.descriptionNetwork(),
"400px"); //$NON-NLS-1$
- getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.addNetworkNetwork()) {
- @Override
- protected UICommand resolveCommand() {
- return getDetailModel().getNewNetworkCommand();
- }
- });
+ if (ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly)) {
+ getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.addNetworkNetwork()) {
+ @Override
+ protected UICommand resolveCommand() {
+ return getDetailModel().getNewNetworkCommand();
+ }
+ });
- getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.assignDetatchNetworksNework()) {
- @Override
- protected UICommand resolveCommand() {
- return getDetailModel().getManageCommand();
- }
- });
+ getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.assignDetatchNetworksNework()) {
+ @Override
+ protected UICommand resolveCommand() {
+ return getDetailModel().getManageCommand();
+ }
+ });
- getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.setAsDisplayNetwork()) {
- @Override
- protected UICommand resolveCommand() {
- return getDetailModel().getSetAsDisplayCommand();
- }
- });
+ getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.setAsDisplayNetwork()) {
+ @Override
+ protected UICommand resolveCommand() {
+ return getDetailModel().getSetAsDisplayCommand();
+ }
+ });
+ }
}
}
--
To view, visit http://gerrit.ovirt.org/22189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2436c11b51f6707c70aef426e1e253ff958fa6dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
