Omer Frenkel has posted comments on this change.
Change subject: core,frontend: show template name also for cloned VMs
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 69: if (isVmExist()) {
Line 70: setCustomDefinedProperties(parameters.getVmStaticData());
Line 71: setCustomDefinedProperties(getVm().getStaticData());
Line 72:
Line 73: // not editable
this is not needed, it is handled in can do action with the @editable
Line 74:
getParameters().getVm().setOriginalTemplateName(getVm().getOriginalTemplateName());
Line 75:
getParameters().getVm().setOriginalTemplateGuid(getVm().getOriginalTemplateGuid());
Line 76: }
Line 77: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
Line 251: .addValue("vds_id", vdsId));
Line 252: }
Line 253:
Line 254: @Override
Line 255: public void updateOriginalTemplateName(Guid originalTemplateId,
String originalTemplateName) {
what about a test for this?
Line 256:
getCallsHandler().executeModification("UpdateOriginalTemplateName",
Line 257: getCustomMapSqlParameterSource()
Line 258: .addValue("original_template_id",
originalTemplateId)
Line 259: .addValue("original_template_name",
originalTemplateName)
....................................................
File
packaging/dbscripts/upgrade/03_04_0100_add_original_template_to_vm_static.sql
Line 1: select fn_db_add_column('vm_static', 'original_template_id', 'UUID
default null');
if you want to remove the 'original' and have a 'cleaner' solution (but more
changes required), you can use the existing vmt_guid instead of adding another
(kinda duplicate) id field, and just save the template name (in case its
deleted) and save the provision method used (clone/thin)
--
To view, visit http://gerrit.ovirt.org/21047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea4ad7c1ed845d3ff57aaafc19f0830ab72b2d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
