Sahina Bose has posted comments on this change.
Change subject: engine: Log when gluster task started from CLI
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 256:
Line 257: AuditLogType logType;
Line 258: switch (task.getType()) {
Line 259: case REBALANCE:
Line 260: logType =
AuditLogType.GLUSTER_VOLUME_REBALANCE_START_DETECTED_FROM_CLI;
I thought map is an overkill here considering there are only 2 task types. Can
refactor to use map if the need arises.
Line 261: break;
Line 262: case REMOVE_BRICK:
Line 263: logType =
AuditLogType.START_REMOVING_GLUSTER_VOLUME_BRICKS_DETECTED_FROM_CLI;
Line 264: values.put(GlusterConstants.BRICK,
StringUtils.join(task.getTaskParameters().getBricks(), ','));
--
To view, visit http://gerrit.ovirt.org/22078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381ecc028ff5dd36202916953f5c3c623b43e526
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
