Arik Hadas has posted comments on this change.
Change subject: core: scheduling: handle cpu load duration
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
1 minor comment, except that it looks ok
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 470: if (isVdsUpOrGoingToMaintenance) {
Line 471: // check if its time for statistics refresh
Line 472: if (_vdsManager.getRefreshStatistics() ||
_vds.getStatus() == VDSStatus.PreparingForMaintenance) {
Line 473: refreshVdsStats();
Line 474:
ResourceManager.getInstance().getEventListener().updateSchedulingStats(_vds);
I think it is better to move it to refreshVdsStats
Line 475: } else {
Line 476: /**
Line 477: * TODO: Omer if vds team will not implement
events to 4.2 please call here to refreshVdsStats -
Line 478: * refresh dynamic data
--
To view, visit http://gerrit.ovirt.org/22176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I231aa54ccc0cadbd9456b090fe08ae85dd926957
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
