Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: validate shell scripts ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File Makefile Line 313: validations: generated-files Line 314: if [ "$(BUILD_VALIDATION)" != 0 ]; then \ Line 315: build/shell-check.sh && \ Line 316: build/python-check.sh && \ Line 317: build/dbscripts/check_for_duplicate_upgrade_scripts.sh; \ The last one previously was done also if BUILD_VALIDATION was 0. Is this wanted? Line 318: fi Line 319: Line 320: install_artifacts: Line 321: # we must exclude tmp.repos directory so we -- To view, visit http://gerrit.ovirt.org/22332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib16140e4abcb3740a51f4c3b77b9eee3a6e5cffd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
