Martin Sivák has posted comments on this change.

Change subject: changed the loggers names to use hierachy
......................................................................


Patch Set 1:

(1 comment)

....................................................
File ovirt_hosted_engine_ha/agent/agent.py
Line 120:                 logging.getLogger('').addHandler(handler)
Line 121:         except (ConfigParser.Error, ImportError, NameError, 
TypeError):
Line 122:             logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 123:                                 level=logging.DEBUG)
Line 124:             log = logging.getLogger("%s.Broker" % (__name__))
The brackets have no effect here.
Line 125:             log.warn("Could not inititialize logging", exc_info=True)
Line 126:         self._log = logging.getLogger("%s.Broker" % (__name__))
Line 127: 
Line 128:     def _get_signal_map(self):


-- 
To view, visit http://gerrit.ovirt.org/22371
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40fb7aca813800dd445e858406034736817cac9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to