Alon Bar-Lev has posted comments on this change.

Change subject: utils: osinfo: do not use absolute paths
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
Line 345:     }
Line 346: 
Line 347:     @Override
Line 348:     public String getSysprepPath(int osId, Version version) {
Line 349:         return 
EngineLocalConfig.getInstance().expandString(getValueByVersion(idToUnameLookup.get(osId),
 "sysprepPath", version));
I do not care how it is done... please modify this patch however you see fit. 
This is the layout created for you to ease test and progress.

Thanks!
Line 350:     }
Line 351: 
Line 352:     @Override
Line 353:     public String getProductKey(int osId, Version version) {


-- 
To view, visit http://gerrit.ovirt.org/22383
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51be14104b73214602c491383fde6b34ef4f094c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to