Hello Ofer Schreiber,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22388
to review the following change.
Change subject: packging: Pass full log path to database schema creation script
......................................................................
packging: Pass full log path to database schema creation script
Don't pass a relative path to database schema creation script, as it will
create the log file under current directory.
Change-Id: Iceb095d05473f41da4fa56eadc6e60da14056ac2
Bug-Url: https://bugzilla.redhat.com/1040026
Signed-off-by: Ofer Schreiber <[email protected]>
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-dwh refs/changes/88/22388/1
diff --git a/packaging/ovirt-engine-dwh-setup.py
b/packaging/ovirt-engine-dwh-setup.py
index 5a001a6..86e5b50 100755
--- a/packaging/ovirt-engine-dwh-setup.py
+++ b/packaging/ovirt-engine-dwh-setup.py
@@ -147,8 +147,8 @@
"""
logging.debug("installing %s db", DB_NAME)
- dbLogFilename = "ovirt-history-db-install-%s.log"
%(utils.getCurrentDateTime())
- logging.debug("ovirt engine history db creation is logged at %s/%s" %
("/var/log/ovirt-engine", dbLogFilename))
+ dbLogFilename = "%s/ovirt-history-db-install-%s.log"
%("/var/log/ovirt-engine", utils.getCurrentDateTime())
+ logging.debug("ovirt engine history db creation is logged at %s" %
(dbLogFilename))
cmd = [
os.path.join(PATH_DB_SCRIPTS, EXEC_CREATE_SCHEMA),
--
To view, visit http://gerrit.ovirt.org/22388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iceb095d05473f41da4fa56eadc6e60da14056ac2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
