Omer Frenkel has posted comments on this change.
Change subject: core: Add snapshot broken status (#817520)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 257: ||
!validate(snapshotsValidator.snapshotNotBroken(getSnapshot()))) {
if the snapshot is null the user will not get any error message for the failure
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 165: &&
validate(snapshotsValidator.snapshotNotBroken(snapshot));
isn't it possible to use the same snap. validator twice?
--
To view, visit http://gerrit.ovirt.org/4067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b90782abc00bcd12652086343a762d08b2e440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
