Alissa Bonas has uploaded a new change for review.

Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors
......................................................................

frontend: ignore in findbugs EventArgs unconfirmed cast errors

Ignore in findbugs errors related to casting EventArgs.
Fix existing exclude filters that stopped working due to
refactoring introduced in some recent patches
that caused the order and the number
of anonymous classes that contained findbugs warnings to change.
The casting is safe in this case, and a future refactoring
will make findbug warning resolved in any case.(RFE #1034844)

Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33
Signed-off-by: Alissa Bonas <[email protected]>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/22409/1

diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml 
b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
index 6882968..af2200e 100644
--- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
+++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
@@ -193,17 +193,17 @@
     </Match>
 
     <Match>
-        <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$17"
 />
+        <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$21"
 />
        <Bug pattern="BC_UNCONFIRMED_CAST"/>
     </Match>
 
     <Match>
-       <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$20"
 />
+       <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$24"
 />
        <Bug pattern="BC_UNCONFIRMED_CAST"/>
     </Match>
 
     <Match>
-       <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$23"
 />
+       <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$25"
 />
        <Bug pattern="BC_UNCONFIRMED_CAST"/>
     </Match>
 


-- 
To view, visit http://gerrit.ovirt.org/22409
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to