Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Update list box upon arrow key press
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Giving +1 as Daniel commented on this patch too, for me the workaround looks 
good.

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java
Line 45:                     Scheduler.get().scheduleDeferred(new 
ScheduledCommand() {
Line 46: 
Line 47:                         @Override
Line 48:                         public void execute() {
Line 49:                             
DomEvent.fireNativeEvent(Document.get().createChangeEvent(), asListBox());
Nice trick to fire native event on DOM element :-)
Line 50:                         }
Line 51:                     });
Line 52:                 }
Line 53:             }


-- 
To view, visit http://gerrit.ovirt.org/21719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc9ac7e82c6d1c86886907cecd6eb5b83ac8444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to