Daniel Erez has posted comments on this change.
Change subject: core, engine: sPAPR SCSI on PPC64 VMs
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java
Line 5:
Line 6: public enum DiskInterface {
Line 7:
Line 8: IDE("ide", "ide"),
Line 9: VirtIO_SCSI("virtio-scsi", "scsi"),
Right, the forValue is probably redundant now as the value we pass to vdsm
isn't unique ('scs' for both VirtIO_SCSI and SPAPR_VSCSI). If the name of the
interface is needed we can use .toString() or preferably .name().
Line 10: VirtIO("virtio", "virtio"),
Line 11: SPAPR_VSCSI("spapr-vscsi", "scsi");
Line 12:
Line 13: private String name;
--
To view, visit http://gerrit.ovirt.org/18622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4fefa225cb44f0e09a7a056e07b8393dda6819b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
