Arik Hadas has uploaded a new change for review. Change subject: core: add missing log on failure to run stateless vm ......................................................................
core: add missing log on failure to run stateless vm The audit log message which says that run VM operation fail when VM cannot run after stateless snapshot was created for it was not created. This patch make sure that this audit log message will be created in that case. Change-Id: Ife723bfada1785028a5fa2bc27170fa42a611df9 Bug-Url: https://bugzilla.redhat.com/1039507 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/22451/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java index ab6da1d..22777e1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java @@ -883,8 +883,9 @@ .runInternalAction(getActionType(), getParameters(), new CommandContext(runStatelessVmCtx)) .getSucceeded()); if (!getSucceeded()) { - // could not run the vm don't try to run the end action again + getParameters().setShouldBeLogged(true); log.warnFormat("Could not run the vm {0} on RunVm.EndSuccessfully", getVm().getName()); + // could not run the vm don't try to run the end action again getReturnValue().setEndActionTryAgain(false); } } -- To view, visit http://gerrit.ovirt.org/22451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife723bfada1785028a5fa2bc27170fa42a611df9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
