Yair Zaslavsky has posted comments on this change. Change subject: core: some NFS mount options cleanup and test ......................................................................
Patch Set 1: Please see usage of LiveSnapshotEnabled and LocalStorageEnabled (and others ) as example. We do not specify the version inside a config value to enable disable a feature, but provide a set of values per each version. This may seem redundant , and we might consider improving this later on, but for now , please conform to the current way we do it (i.e - have entries for 2.2., 3.0, 3.1 of AdvanceNfsOptionsEnabled - true for 3.1 , false for 2.2 and 3.0). Thanks! -- To view, visit http://gerrit.ovirt.org/4091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b255acd5e1b7571509a35bc24b0ccccc58472d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
