Lior Vernia has uploaded a new change for review. Change subject: webadmin: Block profile creation even if network's flushed ......................................................................
webadmin: Block profile creation even if network's flushed A previous fix neglected the fact that the Edit Network dialog could be flushed but remain open, e.g. as in the case of a failed backend action. This patch disables the profile creation logic in that case as well. Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1 Bug-Url: https://bugzilla.redhat.com/1043386 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/22508/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java index 343ed03..6383d48 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java @@ -14,8 +14,11 @@ public class EditNetworkModel extends NetworkModel { + private final boolean originallyVmNetwork; + public EditNetworkModel(Network network, ListModel sourceListModel) { super(network, sourceListModel); + originallyVmNetwork = network.isVmNetwork(); getDataCenters().setIsChangable(false); init(); } @@ -97,6 +100,6 @@ @Override protected void toggleProfilesAvailability() { - getProfiles().setIsAvailable((Boolean) getIsVmNetwork().getEntity() && !getNetwork().isVmNetwork()); + getProfiles().setIsAvailable((Boolean) getIsVmNetwork().getEntity() && !originallyVmNetwork); } } -- To view, visit http://gerrit.ovirt.org/22508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
