Eli Mesika has posted comments on this change.

Change subject: engine: Delete jobs that their steps have no async-tasks
......................................................................


Patch Set 3:

(2 comments)

....................................................
File packaging/dbscripts/job_sp.sql
Line 483:     AND ((end_time < v_succeeded_end_time
Line 484:     AND    status = 'FINISHED')
Line 485:     OR    (end_time < v_failed_end_time
Line 486:     AND    status IN ('FAILED', 'ABORTED', 'UNKNOWN'))));
Line 487:     
Please remove all heading TABS and trailing white spaces , indentation should 
be 4 regular spaces
Line 488:     DELETE FROM job
Line 489:     WHERE job_id IN
Line 490:       (SELECT job.job_id 
Line 491:       FROM job,step 


Line 488:     DELETE FROM job
Line 489:     WHERE job_id IN
Line 490:       (SELECT job.job_id 
Line 491:       FROM job,step 
Line 492:       WHERE job.is_external = false 
can be 
where NOT job.is_external
Line 493:               AND job.job_id = step.job_id 
Line 494:               AND step.step_id NOT IN 
Line 495:                       (SELECT async_tasks.step_id 
Line 496:                       FROM async_tasks, step 


-- 
To view, visit http://gerrit.ovirt.org/22474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae00d615bff79f42d8428b867f1816d6e0aa9a72
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to