Omer Frenkel has posted comments on this change.
Change subject: core: [Fix] PCI limit in add watchdog
......................................................................
Patch Set 4:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 116: protected boolean isVirtioScsiControllerAttached(Guid vmId) {
Line 117: return VmDeviceUtils.isVirtioScsiControllerAttached(vmId);
Line 118: }
Line 119:
Line 120: protected boolean isWatchdogSetted(Guid vmId) {
it would be more correct to rephrase this to 'hasWatchdog' or 'watchdogExists'
Line 121: return VmDeviceUtils.isWatchdogSetted(vmId);
Line 122: }
Line 123:
Line 124: protected boolean isDiskCanBeAddedToVm(Disk diskInfo, VM vm) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 539:
VmDeviceUtils.isVirtioScsiControllerAttached(getVmId());
Line 540: }
Line 541:
Line 542: protected boolean isWatchdogSetted() {
Line 543: if (getParameters().isUpdateWatchdog()
even if watchdog is not set to be updated, it might already exist in the vm,
and need to be taken into account
Line 544: && getParameters().getWatchdog() != null) {
Line 545: return true;
Line 546: }
Line 547:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 127: return returnValue;
Line 128: }
Line 129:
Line 130: protected boolean isWatchdogSetted() {
Line 131: if (getParameters().isUpdateWatchdog()
also here
Line 132: && getParameters().getWatchdog() != null) {
Line 133: return true;
Line 134: }
Line 135:
--
To view, visit http://gerrit.ovirt.org/22491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6b8fdd4b0b3a56e838c1252515b3b5391de22a9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
