Juan Hernandez has uploaded a new change for review. Change subject: core: Findbugs exclussions in JBoss modules plugin ......................................................................
core: Findbugs exclussions in JBoss modules plugin The code generated by Maven for the JBoss modules plugin contains a class that has an minor issue pointed out by findbugs. These issue has already been reported to the maven developers: http://jira.codehaus.org/browse/MPLUGIN-255 While this is solved in Maven we are adding a findbugs configuration to ignore it. This configuration is the same used in all the rest of the engine modules, the only difference is the exclussions list. Change-Id: I76106b935e0e987db04d99e36f89adc536754021 Signed-off-by: Juan Hernandez <[email protected]> --- A build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml 2 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/22659/1 diff --git a/build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml b/build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml new file mode 100644 index 0000000..2f2a84a --- /dev/null +++ b/build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml @@ -0,0 +1,9 @@ +<FindBugsFilter> + + <!-- Don't check the code generated by Maven, as one of the classes has a + minor issue, see MPLUGIN-255: --> + <Match> + <Class name="org.ovirt.engine.build.HelpMojo"/> + </Match> + +</FindBugsFilter> diff --git a/build-tools-root/jboss-modules-maven-plugin/pom.xml b/build-tools-root/jboss-modules-maven-plugin/pom.xml index 956071b..66b31cc 100644 --- a/build-tools-root/jboss-modules-maven-plugin/pom.xml +++ b/build-tools-root/jboss-modules-maven-plugin/pom.xml @@ -102,4 +102,47 @@ </build> + <profiles> + + <profile> + <id>findbugs</id> + <activation> + <activeByDefault>true</activeByDefault> + </activation> + <build> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <excludeFilterFile>${basedir}/exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> + </plugins> + </build> + </profile> + + <profile> + <id>findbugs-general</id> + <build> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <excludeFilterFile>${basedir}/exclude-filters.xml,${basedir}/../../exclude-filters-general.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> + </plugins> + </build> + </profile> + + </profiles> + </project> -- To view, visit http://gerrit.ovirt.org/22659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I76106b935e0e987db04d99e36f89adc536754021 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
