Moti Asayag has posted comments on this change.
Change subject: core: Added command id to parameters
......................................................................
Patch Set 1: (1 inline comment)
I have a concern about putting the final for the command-id. See comment inside.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 97: new ArrayList<Class<?>>(Arrays.asList(new Class<?>[] {
Default.class }));
what about when performing the endAction ? in that case we instantiate the
command to perform the endAction, however the command-id gets a new id than the
command-id which actually is used to run the task.
And suppose we wishes to invoke another command with tasks, we'd loose that
information.
--
To view, visit http://gerrit.ovirt.org/4125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8673ccdcb446784e30f1aee0329debf689a682d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
