Daniel Erez has posted comments on this change.
Change subject: webadmin: resolve findbugs warning in HumanReadableTimeRenderer.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HumanReadableTimeRenderer.java
Line 11: public String render(Double time) {
Line 12: StringBuilder formatTime = new StringBuilder();
Line 13:
Line 14: if ( time > SECONDS_IN_A_DAY) {
Line 15: formatTime.append((int)(time/SECONDS_IN_A_DAY));
doesn't the formatter enforce a space after casting?
Line 16: formatTime.append(" days " );//$NON-NLS-1$
Line 17: time = time % SECONDS_IN_A_DAY;
Line 18: }
Line 19: if( time > SECONDS_IN_AN_HOUR ) {
--
To view, visit http://gerrit.ovirt.org/22700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia14f49fd458f3384ba4829d2e4fc4301ad6de4ee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
