Alissa Bonas has uploaded a new change for review. Change subject: ui: rename members to start with lowercase in SpiceConsoleModel ......................................................................
ui: rename members to start with lowercase in SpiceConsoleModel Solves 4 findbugs warnings Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 2 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/22703/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java index c9537a7..b17be58 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java @@ -17,13 +17,13 @@ public abstract class AbstractSpice { protected Event disconnectedEvent = new Event( - SpiceConsoleModel.SpiceDisconnectedEventDefinition); + SpiceConsoleModel.spiceDisconnectedEventDefinition); protected Event connectedEvent = new Event( - SpiceConsoleModel.SpiceConnectedEventDefinition); + SpiceConsoleModel.spiceConnectedEventDefinition); protected Event menuItemSelectedEvent = new Event( - SpiceConsoleModel.SpiceMenuItemSelectedEventDefinition); + SpiceConsoleModel.spiceMenuItemSelectedEventDefinition); protected Event usbAutoShareChangedEvent = new Event( - SpiceConsoleModel.UsbAutoShareChangedEventDefinition); + SpiceConsoleModel.usbAutoShareChangedEventDefinition); protected final Event wanColorDepthChangedEvent = new Event( SpiceConsoleModel.wanColorDepthChangedEventDefinition); protected final Event wanDisableEffectsChangeEvent = new Event( diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java index 9d903ed..80c230c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java @@ -54,10 +54,10 @@ public enum ClientConsoleMode { Native, Plugin, Auto, Html5 } - public static EventDefinition SpiceDisconnectedEventDefinition; - public static EventDefinition SpiceConnectedEventDefinition; - public static EventDefinition SpiceMenuItemSelectedEventDefinition; - public static EventDefinition UsbAutoShareChangedEventDefinition; + public static EventDefinition spiceDisconnectedEventDefinition; + public static EventDefinition spiceConnectedEventDefinition; + public static EventDefinition spiceMenuItemSelectedEventDefinition; + public static EventDefinition usbAutoShareChangedEventDefinition; public static EventDefinition wanColorDepthChangedEventDefinition; public static EventDefinition wanDisableEffectsChangeEventDefinition; @@ -74,10 +74,10 @@ } static { - SpiceDisconnectedEventDefinition = new EventDefinition("SpiceDisconnected", SpiceConsoleModel.class); //$NON-NLS-1$ - SpiceConnectedEventDefinition = new EventDefinition("SpiceConnected", SpiceConsoleModel.class); //$NON-NLS-1$ - SpiceMenuItemSelectedEventDefinition = new EventDefinition("SpiceMenuItemSelected", SpiceConsoleModel.class); //$NON-NLS-1$ - UsbAutoShareChangedEventDefinition = new EventDefinition("UsbAutoShareChanged", SpiceConsoleModel.class); //$NON-NLS-1$ + spiceDisconnectedEventDefinition = new EventDefinition("SpiceDisconnected", SpiceConsoleModel.class); //$NON-NLS-1$ + spiceConnectedEventDefinition = new EventDefinition("SpiceConnected", SpiceConsoleModel.class); //$NON-NLS-1$ + spiceMenuItemSelectedEventDefinition = new EventDefinition("SpiceMenuItemSelected", SpiceConsoleModel.class); //$NON-NLS-1$ + usbAutoShareChangedEventDefinition = new EventDefinition("UsbAutoShareChanged", SpiceConsoleModel.class); //$NON-NLS-1$ wanColorDepthChangedEventDefinition = new EventDefinition("ColorDepthChanged", SpiceConsoleModel.class); //$NON-NLS-1$ wanDisableEffectsChangeEventDefinition = new EventDefinition("DisableEffectsChange", SpiceConsoleModel.class); //$NON-NLS-1$ } -- To view, visit http://gerrit.ovirt.org/22703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
