Eli Mesika has uploaded a new change for review. Change subject: [cleanup] code: Removing an unused method ......................................................................
[cleanup] code: Removing an unused method The getValueFromDBDefault method is not used and can be removed from code safely. Change-Id: I545c597c0532fed476e520cf95059d515328b878 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java 1 file changed, 0 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/22709/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java index 066f92b..69c9fcd 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java @@ -188,23 +188,6 @@ } } - private static String getValueFromDBDefault(ConfigValues name) { - String returnValue = null; - Map<String, Object> values = null; - if ((values = _vdcOptionCache.get(name.toString())) != null - && values.containsKey(ConfigCommon.defaultConfigurationVersion)) { - returnValue = (String) values.get(ConfigCommon.defaultConfigurationVersion); - } else { - VdcOption option = DbFacade.getInstance().getVdcOptionDao().getByNameAndVersion(name.name(), - ConfigCommon.defaultConfigurationVersion); - if (option != null) { - returnValue = option.getoption_value(); - } - } - - return returnValue; - } - @Override protected Object getValue(DataType type, String name, String defaultValue) { // Note that the type parameter is useless, it should be removed (and -- To view, visit http://gerrit.ovirt.org/22709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I545c597c0532fed476e520cf95059d515328b878 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
