Alissa Bonas has uploaded a new change for review. Change subject: ui: rename members to start with lowercase in several classes ......................................................................
ui: rename members to start with lowercase in several classes Solves findbugs warnings. Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 14 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/22713/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java index 68305ae..57f4ad6 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java @@ -12,7 +12,7 @@ // public event EventHandler Executed = delegate { }; - public static EventDefinition ExecutedEventDefinition; + public static EventDefinition executedEventDefinition; private Event privateExecutedEvent; public Event getExecutedEvent() @@ -39,12 +39,12 @@ static { - ExecutedEventDefinition = new EventDefinition("Executed", ChangeCDModel.class); //$NON-NLS-1$ + executedEventDefinition = new EventDefinition("Executed", ChangeCDModel.class); //$NON-NLS-1$ } public ChangeCDModel() { - setExecutedEvent(new Event(ExecutedEventDefinition)); + setExecutedEvent(new Event(executedEventDefinition)); setDoCommand(new UICommand("Do", this)); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java index 2c282dd..dd31b1e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java @@ -32,7 +32,7 @@ public class PoolGeneralModel extends EntityModel { - public static EventDefinition UpdateCompleteEventDefinition; + public static EventDefinition updateCompleteEventDefinition; private Event privateUpdateCompleteEvent; private static final VmTemplateNameRenderer vmTemplateNameRenderer = new VmTemplateNameRenderer(); @@ -378,12 +378,12 @@ static { - UpdateCompleteEventDefinition = new EventDefinition("UpdateComplete", PoolGeneralModel.class); //$NON-NLS-1$ + updateCompleteEventDefinition = new EventDefinition("UpdateComplete", PoolGeneralModel.class); //$NON-NLS-1$ } public PoolGeneralModel() { - setUpdateCompleteEvent(new Event(UpdateCompleteEventDefinition)); + setUpdateCompleteEvent(new Event(updateCompleteEventDefinition)); setTitle(ConstantsManager.getInstance().getConstants().generalTitle()); setHashName("general"); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java index 95b8244..a7ed056 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java @@ -33,7 +33,7 @@ public class TagListModel extends SearchableListModel { - public static EventDefinition ResetRequestedEventDefinition; + public static EventDefinition resetRequestedEventDefinition; private Event privateResetRequestedEvent; public Event getResetRequestedEvent() @@ -160,12 +160,12 @@ static { - ResetRequestedEventDefinition = new EventDefinition("ResetRequested", SystemTreeModel.class); //$NON-NLS-1$ + resetRequestedEventDefinition = new EventDefinition("ResetRequested", SystemTreeModel.class); //$NON-NLS-1$ } public TagListModel() { - setResetRequestedEvent(new Event(ResetRequestedEventDefinition)); + setResetRequestedEvent(new Event(resetRequestedEventDefinition)); setNewCommand(new UICommand("New", this)); //$NON-NLS-1$ setEditCommand(new UICommand("Edit", this)); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java index 305bc87..705244c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java @@ -73,7 +73,7 @@ @Override public void eventRaised(Event ev, Object sender, EventArgs args) { - if (ev.matchesDefinition(ChangeCDModel.ExecutedEventDefinition)) + if (ev.matchesDefinition(ChangeCDModel.executedEventDefinition)) { changeCD(sender, args); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java index 446beeb..51d6158 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java @@ -1,11 +1,14 @@ package org.ovirt.engine.ui.uicommonweb.models.vms; +import static org.ovirt.engine.ui.uicommonweb.ConsoleOptionsFrontendPersister.ConsoleContext; + import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Map.Entry; + import org.ovirt.engine.core.common.VdcActionUtils; import org.ovirt.engine.core.common.action.AddVmFromScratchParameters; import org.ovirt.engine.core.common.action.AddVmFromTemplateParameters; @@ -84,8 +87,6 @@ import org.ovirt.engine.ui.uicompat.IFrontendMultipleQueryAsyncCallback; import org.ovirt.engine.ui.uicompat.ObservableCollection; import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; - -import static org.ovirt.engine.ui.uicommonweb.ConsoleOptionsFrontendPersister.ConsoleContext; public class VmListModel extends VmBaseListModel<VM> implements ISupportSystemTreeContext { @@ -2308,7 +2309,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(ChangeCDModel.ExecutedEventDefinition)) + if (ev.matchesDefinition(ChangeCDModel.executedEventDefinition)) { changeCD(sender, args); } -- To view, visit http://gerrit.ovirt.org/22713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
