Moti Asayag has posted comments on this change. Change subject: core: Validate network label format ......................................................................
Patch Set 7: (1 comment) As stated in the feature page, the format to start with is the suggested one. We can always alter it to be more permissive based on users request. .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 470: NETWORK_ALREADY_ATTACHED_TO_INTERFACE=Logical Network is already attached to a Network Interface. Line 471: NETWORK_NOT_EXISTS=The specified Logical Network doesn't exist. Line 472: ACTION_TYPE_FAILED_NETWORK_QOS_NOT_EXISTS=The specified Network QoS doesn't exist. Line 473: EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED=The specified external network cannot be configured on the host's interface. Line 474: NETWORK_LABEL_FORMAT_INVALID=Network label must be formed of "a-z0-9A-Z" or "-_" There message i used is the same message appears in most places in this file where a name format isn't valid. I don't see any need to reinvent an existing message. Line 475: ERROR_CANNOT_RECOVERY_STORAGE_POOL_THERE_IS_ACTIVE_DATA_DOMAINS=Cannot recover Data Center with active Data Storage Domain in Data Center. Line 476: ERROR_CANNOT_RECOVERY_STORAGE_POOL_STORAGE_TYPE_MISSMATCH=Cannot recover Data Center. Mismatch between Storage Domain type and Data Center type. Line 477: ERROR_CANNOT_DETACH_LAST_STORAGE_DOMAIN=Cannot remove the master Storage Domain from the Data Center without another active Storage Domain to take its place.\n\ Line 478: -Either activate another Storage Domain in the Data Center, or remove the Data Center. -- To view, visit http://gerrit.ovirt.org/22654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id645a96af80ef5de4d6239de64faba04026c8cd2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
