Yaniv Dary has posted comments on this change.

Change subject: packaging: changed major version to 3.4
......................................................................


Patch Set 1:

(1 comment)

....................................................
File Makefile
Line 259:               install-packaging-files \
Line 260:               $(NULL)
Line 261: 
Line 262:       install -dm 755 
"$(DESTDIR)$(SYSCONF_DIR)/ovirt-engine/ovirt-engine-dwh"
Line 263:       install -m 660 
ovirt-engine-dwh/historyETL/src/main/resources/ovirt_engine_dwh/historyetl_3_4/contexts/Default.properties
 "$(DESTDIR)$(SYSCONF_DIR)/ovirt-engine/ovirt-engine-dwh"
It fails after I apply this change:

install -m 660 
ovirt-engine-dwh/historyETL/src/main/resources/ovirt_engine_dwh/historyetl_$(echo
 3.4.0 | sed 's/./_/g'))/contexts/Default.properties 
"/home/ydary/rpmbuild/BUILDROOT/ovirt-engine-dwh-3.4.0-0.2.master.20131225001345.fc19.x86_64/etc/ovirt-engine/ovirt-engine-dwh"
/bin/sh: -c: line 0: syntax error near unexpected token `)'
/bin/sh: -c: line 0: `install -m 660 
ovirt-engine-dwh/historyETL/src/main/resources/ovirt_engine_dwh/historyetl_$(echo
 3.4.0 | sed 's/./_/g'))/contexts/Default.properties 
"/home/ydary/rpmbuild/BUILDROOT/ovirt-engine-dwh-3.4.0-0.2.master.20131225001345.fc19.x86_64/etc/ovirt-engine/ovirt-engine-dwh"'
make: *** [install-layout] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.nJby15 (%install)
Line 264: 
Line 265:       install -dm 755 "$(DESTDIR)$(BIN_DIR)"
Line 266:       ln -sf "$(PKG_DATA_DIR)/legacy-setup/ovirt-engine-dwh-setup.py" 
"$(DESTDIR)$(BIN_DIR)/ovirt-engine-dwh-setup"
Line 267: 


-- 
To view, visit http://gerrit.ovirt.org/22692
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I287ecd8c016510036a2c669d4cc1e0afbfc89f63
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to