Maor Lipchuk has posted comments on this change.
Change subject: core: Add a validation when deactivate ISO domain.
......................................................................
Patch Set 12:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 151: if (getVmDynamicDAO().get(vmStatic.getId()).getStatus()
!= VMStatus.Down
Line 152: &&
VmDeviceUtils.isVMHasAttachedISO(vmStatic.getId())) {
Line 153: vmNames.add(vmStatic.getName());
Line 154: }
Line 155: }
1. I don't see it that way
2. this can be addressed in another patch later
Line 156: return vmNames;
Line 157: }
Line 158:
Line 159: /**
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 110: VmDeviceGeneralType.DISK);
Line 111: for (VmDevice device : deviceList) {
Line 112: if
(device.getDevice().equals(VmDeviceType.CDROM.toString())
Line 113: ||
device.getDevice().equals(VmDeviceType.FLOPPY.toString())) {
Line 114: String path = (String)
device.getSpecParams().get("path");
again, CDROM and Floppy should be plugged, if they are not, it is a bug.
ether way we don't need to address that in this patch
Line 115: if (!StringUtils.isEmpty(path)) {
Line 116: return true;
Line 117: }
Line 118: }
--
To view, visit http://gerrit.ovirt.org/20331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
