Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding affinity groups command and queries
......................................................................
Patch Set 5:
(2 comments)
More comments -
1. Are the crud commands monitored or not? You should make them non monitored
if you don't want to get bugs that there is a missing execution message at the
tasks monitor.
2. For the sake of notification - you need to add some entries at event_map -
consult with Mooli or Moti on this.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
Line 35: if (getParameters().getAffinityGroup().getVmIds() != null) {
Line 36: VmStatic vmStatic = null;
Line 37: Set<Guid> vmSet = new HashSet<Guid>();
Line 38: for (Guid vmId :
getParameters().getAffinityGroup().getVmIds()) {
Line 39: vmStatic = getVmStaticDAO().get(vmId);
Hmm... how frequent is this going be called ? Yes I now we have loops of select
in other places, but still?
Line 40: if (vmStatic == null) {
Line 41: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_INVALID_VM_FOR_AFFINITY_GROUP);
Line 42: }
Line 43: if (!vmStatic.getVdsGroupId().equals(getVdsGroupId()))
{
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 1093: AFFINITY_GROUP_NAME_INVALID=Cannot ${action} ${type}. Name field is
invalid.
Line 1094: AFFINITY_GROUP_DESCRIPTION_INVALID=Cannot ${action} ${type}.
Description field is invalid.
Line 1095: ACTION_TYPE_FAILED_AFFINITY_GROUP_INVALID_CLUSTER_ID=Cannot
${action} ${type}. Cluster is empty.
Line 1096: ACTION_TYPE_FAILED_INVALID_CLUSTER_FOR_AFFINITY_GROUP=Cannot
${action} ${type}. Provided Cluster is invalid.
Line 1097: ACTION_TYPE_FAILED_INVALID_VM_FOR_AFFINITY_GROUP=Cannot ${action}
${type}. Provided VM is invalid (no exists).
s/no exists/does not exist
Line 1098: ACTION_TYPE_FAILED_VM_NOT_IN_AFFINITY_GROUP_CLUSTER=Cannot ${action}
${type}. Provided VM resides in another Cluster.
Line 1099: ACTION_TYPE_FAILED_DUPLICTE_VM_IN_AFFINITY_GROUP=Cannot ${action}
${type}. Duplicate VM.
Line 1100: ACTION_TYPE_FAILED_INVALID_AFFINITY_GROUP_ID=Cannot ${action}
${type}. No matching Affinity Group.
Line 1101: ACTION_TYPE_FAILED_CANNOT_CHANGE_CLUSTER_ID=Cannot ${action}
${type}. Cannot change Cluster for Affinity Group.
--
To view, visit http://gerrit.ovirt.org/22715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5251d0ee6ff2a719394cdb5ebec7b63e0ae37e3b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
