Oved Ourfali has posted comments on this change.
Change subject: ui: rename EventsArgs.Empty to empty
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventArgs.java
Line 1: package org.ovirt.engine.ui.uicompat;
Line 2:
Line 3: public class EventArgs {
Line 4:
Line 5: public static EventArgs empty;
a thought here... perhaps it should also be declared as final, and then we can
capitalize it.
It will also solve findbugs warning :
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6115/findbugsResult/module.1507119030/file.-2030611833/source.7123/#21
Line 6:
--
To view, visit http://gerrit.ovirt.org/22799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1f2de7e8aaaeb7869864d35da1b4892ad807f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
