Allon Mureinik has posted comments on this change.
Change subject: core: add disk list member to Snapshot entity
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
1. See question inline about List/ArrayList discrepancy - not sure about this
one.
2. When is this new member set? As the patch is, you just introduce dead code.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
Line 212: public void setMemoryVolume(String memoryVolume) {
Line 213: this.memoryVolume = memoryVolume == null ? "" : memoryVolume;
Line 214: }
Line 215:
Line 216: public List<DiskImage> getDiskImages() {
Shouldn't this be defined as an ArrayList for GWT's sake?
Line 217: return diskImages;
Line 218: }
Line 219:
Line 220: public void setDiskImages(List<DiskImage> diskImages) {
Line 216: public List<DiskImage> getDiskImages() {
Line 217: return diskImages;
Line 218: }
Line 219:
Line 220: public void setDiskImages(List<DiskImage> diskImages) {
this too.
Line 221: this.diskImages = diskImages;
Line 222: }
Line 223:
Line 224: @Override
--
To view, visit http://gerrit.ovirt.org/22773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I498f2dc8a5e6d5311b9b4b7fa17c585c293d734e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
