Michael Kublin has posted comments on this change.
Change subject: engine: Import VM more than once (#567580)
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 130: if (retVal) {
First of all, you can write all at the same if, u don't need two ifs , also who
cares about if to use copy collapse or not, when u perform an import as new it
is usually coppy collapse, who cares what user put there
Line 219:
These is a logic should be at execute, not at canDoAction, also u know that for
your flow part of the checks at canDoAction are not relevant and u still
continue to check them
Line 220: if (retVal && getParameters().isImportAsNewEntity()) {
Make that code inside a method
Line 223: setVmId(guid);
u should check if vm with the same name exists
Line 555: }
you don't need to set vm_guid here
--
To view, visit http://gerrit.ovirt.org/4161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa92d494c218b8dd79b3cb20867a806e29c15b6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
