Tal Nisan has posted comments on this change.
Change subject: core: WIP: Adding JPA to ovirt
......................................................................
Patch Set 1:
(2 comments)
....................................................
File backend/manager/modules/common/pom.xml
Line 50: <dependency>
Line 51: <groupId>org.hibernate</groupId>
Line 52: <artifactId>hibernate-entitymanager</artifactId>
Line 53: <version>4.3.0.Final</version>
Line 54: </dependency>
Is it a whitespace at the eol?
Line 55:
Line 56: </dependencies>
Line 57:
Line 58: <build>
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 39: @Size(min = 1, max =
BusinessEntitiesDefinitions.CLUSTER_NAME_SIZE, message =
"VALIDATION.VDS_GROUP.NAME.MAX",
Line 40: groups = {
Line 41: CreateEntity.class, UpdateEntity.class })
Line 42: @ValidI18NName(message = "VALIDATION.VDS_GROUP.NAME.INVALID",
groups = { CreateEntity.class, UpdateEntity.class })
Line 43: @Column(name = "name")
Wouldn't it be better to use it on the getters rather than on the members?
Line 44: private String name;
Line 45:
Line 46: @Size(max = BusinessEntitiesDefinitions.GENERAL_MAX_SIZE)
Line 47: @Column(name = "description")
--
To view, visit http://gerrit.ovirt.org/22806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0bbf9f0913955cb3e1facfa9a4bdc1f1ab24d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
