Michael Pasternak has posted comments on this change. Change subject: sdk: Add session support ......................................................................
Patch Set 2: > I think that this feature shouldn't be exposed to the user at all. I think > that the SDK should automatically use the session > support if provided by the server, including closing the session. the use-case for not using session based auth. is long-run scripts such as backup where user may not want having open session between script executions and use regular (peer request authentication mechanism) > I don't see any advantage in adding the disconnect parameter to the API > constructor, as we already have the API.disconnect method. the /disconnect/ parameter i suggested to add to ctr. of API is meant to indicate which authentication mechanism to use session/regular -- To view, visit http://gerrit.ovirt.org/4044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I098f7195777ee2c93b84b9ef461044b0fc697b10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
