Mike Kolesnik has posted comments on this change.
Change subject: engine: Extract method to create the vlan name
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 235: * @param network
Line 236: * the network which holds the vlan-id
Line 237: * @return a name representing the vlan device
Line 238: */
Line 239: public static String getVlanDeviceName(String underlyingNic,
Network network) {
If you're already trying to simplify, why not accept the NIC as first parameter?
Line 240: return underlyingNic + "." + network.getVlanId();
Line 241: }
--
To view, visit http://gerrit.ovirt.org/22768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic00417b54feb523d8152363ed0986ae9b685f36e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
