Moti Asayag has uploaded a new change for review. Change subject: core: Fix coverity warnings ......................................................................
core: Fix coverity warnings Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/22883/1 diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java index acea43f..88eb2ed 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java @@ -30,9 +30,9 @@ @Test public void checkNetworkLabelFormat() { - Set<ConstraintViolation<NetworkLabelContainer>> validate = - validator.validate(new NetworkLabelContainer(labels)); - assertEquals(expectedResult, validate.isEmpty()); + NetworkLabelContainer labelContainer = new NetworkLabelContainer(labels); + Set<ConstraintViolation<NetworkLabelContainer>> validate = validator.validate(labelContainer); + assertEquals("Failed to validate " + labelContainer.getLabels(), expectedResult, validate.isEmpty()); } @Parameterized.Parameters @@ -50,12 +50,16 @@ }); } - private class NetworkLabelContainer { + private static class NetworkLabelContainer { @ValidNetworkLabelFormat private Set<String> labels; public NetworkLabelContainer(Set<String> labels) { this.labels = labels; } + + public Set<String> getLabels() { + return labels; + } } } -- To view, visit http://gerrit.ovirt.org/22883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I656ff0e494ed90403a1abe0fb8de8b241e5ffb04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
