Daniel Erez has posted comments on this change.
Change subject: core: synchronize lun device size on refreshLunsInfo
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java
Line 68: List<LUNs> lunsFromDb = Arrays.asList(lun, lun);
Line 69:
Line 70: boolean isMismatch =
command.isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb);
Line 71: assertFalse(isMismatch);
Line 72: }
Not sure if needed.. not much logic except updating the DB. I'll see if worth
adding in the context of a separate patch.
Line 73:
Line 74: @Test
Line 75: public void lunsMismatchDeviceSize() {
Line 76: Guid pvID = Guid.newGuid();
Line 89: List<LUNs> lunsFromVgInfo =
Collections.singletonList(lunFromVG);
Line 90: List<LUNs> lunsFromDb = Collections.singletonList(lunFromDB);
Line 91:
Line 92: boolean isMismatch =
command.isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb);
Line 93: assertTrue(isMismatch);
Done
Line 94: }
--
To view, visit http://gerrit.ovirt.org/22887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
