Omer Frenkel has posted comments on this change.
Change subject: core: Hot plug CPU - on create, send max number of cpu
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 70: String.valueOf(vm.getNumOfCpus()));
Line 71: if (Config.<Boolean> getValue(ConfigValues.SendSMPOnRunVm)) {
Line 72: createInfo.put(VdsProperties.cores_per_socket,
Line 73: (Integer.toString(vm.getCpuPerSocket())));
Line 74: if
(vm.getVdsGroupCompatibilityVersion().compareTo(Version.v3_3) == 1) { // TODO
change this when Version 3.4 is added
please use feature supported
Line 75: createInfo.put(VdsProperties.max_number_of_cpus,
Config.<String> getValue(ConfigValues.MaxNumOfVmCpus));
Line 76: }
Line 77: }
Line 78: final String compatibilityVersion =
vm.getVdsGroupCompatibilityVersion().toString();
Line 71: if (Config.<Boolean> getValue(ConfigValues.SendSMPOnRunVm)) {
Line 72: createInfo.put(VdsProperties.cores_per_socket,
Line 73: (Integer.toString(vm.getCpuPerSocket())));
Line 74: if
(vm.getVdsGroupCompatibilityVersion().compareTo(Version.v3_3) == 1) { // TODO
change this when Version 3.4 is added
Line 75: createInfo.put(VdsProperties.max_number_of_cpus,
Config.<String> getValue(ConfigValues.MaxNumOfVmCpus));
where is this config added?
Line 76: }
Line 77: }
Line 78: final String compatibilityVersion =
vm.getVdsGroupCompatibilityVersion().toString();
Line 79: addCpuPinning(compatibilityVersion);
--
To view, visit http://gerrit.ovirt.org/22749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc24a793caecf5ac9f8f38968dd76cba9212074b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
