Moti Asayag has posted comments on this change.
Change subject: engine: Configure network on hosts on cluster assignment
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java
Line 38: if (nicToConfigure == null) {
Line 39: continue;
Line 40: }
Line 41:
Line 42: if (vlanNetwork) {
I'm not sure what will be more clear to the user, since in this matter the
engine creates the duplicate interface. So having an error like: "interface was
sent twice" will be less clear in my opinion.
Line 43: VdsNetworkInterface vlan =
createVlanDevice(nic.getName(), nicToConfigure.getVdsId(), network);
Line 44: setupNetworkParams.getInterfaces().add(vlan);
Line 45: } else if (nicToConfigure.getNetworkName() == null) {
Line 46: nicToConfigure.setNetworkName(network.getName());
--
To view, visit http://gerrit.ovirt.org/22767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ided511feab3a7addffcb1ddc559f32da6cb1873c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
