Moti Asayag has posted comments on this change. Change subject: engine: Edit Network and apply to hosts at once ......................................................................
Patch Set 13: i'm not sure that unit tests will be the right tool to cover the new functionality - it should be covered either by functional tests or by automation test since it evolves configuring network on the hosts and currently we don't have any infra for mocking the vdsServer. However the setup network parameters builder could and should be covered. I'll add unit tests for them once i'm done with the network labels as the code is changed and should be refactored a bit. -- To view, visit http://gerrit.ovirt.org/22053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec04c7fb0c29ba6f61b7d788a9c3917f5d46554e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
