Roy Golan has posted comments on this change. Change subject: core: Hot set number of CPUs using update VM ......................................................................
Patch Set 6: (1 comment) no I didn't tick verify because I saw this and I want to change this .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java Line 172: getModel().getIsDeleteProtected().setEntity(vm.isDeleteProtected()); Line 173: getModel().selectSsoMethod(vm.getSsoMethod()); Line 174: Line 175: getModel().getNumOfSockets().setSelectedItem(vm.getNumOfSockets()); Line 176: getModel().getNumOfSockets().setIsChangable(true); no access to Config.java from frontend. they use ConfigurationValues.java instead. we should port this Frontend somehow have those checks shared though. Line 177: Line 178: getModel().getCoresPerSocket().setIsChangable(!vm.isRunning()); Line 179: Line 180: getModel().getKernel_parameters().setEntity(vm.getKernelParams()); -- To view, visit http://gerrit.ovirt.org/22757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464a3dda5f143d1fcef63fd903eb615b01efe081 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
