Einav Cohen has posted comments on this change. Change subject: core: fix host name validation ......................................................................
Patch Set 1: Looks good to me, but someone else must approve the code looks OK, the only thinks that I am not sure about is the AppErrors-related changes (e.g. changes from "VALIDATION.VDS.NAME.INVALID" to "VALIDATION_VDS_NAME_INVALID") - adding derez as a reviewer to verify that the messages changes are correct. -- To view, visit http://gerrit.ovirt.org/4178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I083afa0aad66651f465c9a70fda07c82367d58ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
