Vitor de Lima has posted comments on this change.
Change subject: core, engine: New validations for host entrance in clusters
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java
Line 104: if (!StringUtils.isEmpty(getVds().getCpuFlags())
Line 105: && (!foundCPU || missingFlags != null)) {
Line 106: if (missingFlags != null) {
Line 107: addCustomValue("CpuFlags",
StringUtils.join(missingFlags, ", "));
Line 108: if (missingFlags.contains("nx")) {
As discussed in the IRC, this flag will never be missing because there are no
flags in ppc64 CPU names.
Line 109: AuditLogableBase logable = new
AuditLogableBase(getVds().getId());
Line 110: AuditLogDirector.log(logable,
AuditLogType.CPU_FLAGS_NX_IS_MISSING);
Line 111: }
Line 112: }
--
To view, visit http://gerrit.ovirt.org/22029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia617481b102b3d5383a0d38da03e10ff95afefe2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
