Moti Asayag has uploaded a new change for review. Change subject: engine: Use an ancestor type in Entities helper class ......................................................................
engine: Use an ancestor type in Entities helper class There is no reason to limit the signature of Entities.hostInterfacesByNetworkName(List) to get list only, since Collection type is suiable as well in that context. The motivation is to allow other caller that would like to provide the Collection type to benefit of this method without need to cast it first to List. Change-Id: I28e2d22feced3a615393fc3c1cf80ea087888f61 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/22940/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java index f809ad0..74b08d3 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java @@ -61,7 +61,7 @@ } } - public static <E extends VdsNetworkInterface> Map<String, E> hostInterfacesByNetworkName(List<E> entityList) { + public static <E extends VdsNetworkInterface> Map<String, E> hostInterfacesByNetworkName(Collection<E> entityList) { if (entityList != null) { Map<String, E> map = new HashMap<String, E>(); for (E e : entityList) { -- To view, visit http://gerrit.ovirt.org/22940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28e2d22feced3a615393fc3c1cf80ea087888f61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
