Maor Lipchuk has posted comments on this change.

Change subject: core: synchronize lun device size on refreshLunsInfo
......................................................................


Patch Set 5:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java
Line 100: 
Line 101:                 if 
(!lunFromDb.getLUN_id().equals(lunFromVgInfo.getLUN_id())) {
Line 102:                     return true;
Line 103:                 }
Line 104:                 else if (lunFromDb.getDeviceSize() != 
lunFromVgInfo.getDeviceSize()) {
disregard, talked with Derez, the if at line 96 should filter this
Line 105:                     // Size mismatch detected - refresh info is needed
Line 106:                     return true;
Line 107:                 }
Line 108:             }


-- 
To view, visit http://gerrit.ovirt.org/22887
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I618880c7b49c226e39f0a0830f1d4f9b71a5f304
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to