Ravi Nori has posted comments on this change.
Change subject: core: AsyncTask fixes
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
Line 41: log.infoFormat("EntityAsyncTask::Adding
EntityMultiAsyncTasks object for entity '{0}'",
Line 42: getContainerId());
Line 43: }
Line 44: EntityMultiAsyncTasks entityInfo = GetEntityMultiAsyncTasks();
Line 45: entityInfo.writeLock();
Should writeLock be called at line 38 before putIfAbsent
Line 46: try {
Line 47: entityInfo.AttachTask(this);
Line 48: } finally {
Line 49: entityInfo.writeUnlock();
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java
Line 95:
Line 96: public EndedTasksInfo getEndedTasksInfo() {
Line 97: EndedTasksInfo endedTasksInfo = new EndedTasksInfo();
Line 98: java.util.ArrayList<EndedTaskInfo> endedTaskInfoList = new
java.util.ArrayList<EndedTaskInfo>();
Line 99: java.util.ArrayList<EntityAsyncTask>
CurrentActionTypeTasks = null;
Can we please change CurrentActionTypeTasks to currentActionTypeTasks with c
lower case
Line 100: readLock();
Line 101: try {
Line 102: CurrentActionTypeTasks = GetCurrentActionTypeTasks();
Line 103: } finally {
--
To view, visit http://gerrit.ovirt.org/8813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c11
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
