Moti Asayag has uploaded a new change for review. Change subject: engine: Skip management network removal if unlabeled ......................................................................
engine: Skip management network removal if unlabeled The management network can be labeled, although it is not the recommended approach: Updating the management network should be updated on any host (i.e. modifying a management network traits). However, unlabeling a management network should not attempt to remove it, as the engine expects any host to be configured with the management network. Change-Id: I9bc86f7c2cd4847892fa0fec15244c286abb088e Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/23053/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java index cdc84bb..80f9530 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java @@ -28,6 +28,11 @@ public ArrayList<VdcActionParametersBase> buildParameters(List<VdsNetworkInterface> nics) { Set<Guid> nonUpdateableHosts = new HashSet<>(); ArrayList<VdcActionParametersBase> parameters = new ArrayList<>(); + + if (NetworkUtils.isManagementNetwork(network)) { + return parameters; + } + boolean vlanNetwork = NetworkUtils.isVlan(network); for (VdsNetworkInterface nic : nics) { -- To view, visit http://gerrit.ovirt.org/23053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9bc86f7c2cd4847892fa0fec15244c286abb088e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
