Roy Golan has posted comments on this change.
Change subject: engine: Display type validation
......................................................................
Patch Set 8:
(2 comments)
minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 409: List<String> reasons,
Line 410: Version clusterVersion) {
Line 411: boolean result =
VmValidationUtils.isDisplayTypeSupported(osId, clusterVersion,
defaultDisplayType);
Line 412: if (!result) {
Line 413:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_VM_DISPLAY_TYPE_IS_NOT_SUPPORTED_BY_OS.toString());
use enum name() instead of toString()
Line 414: }
Line 415: return result;
Line 416: }
Line 417:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
Line 76: SimpleDependecyInjector.getInstance().bind(OsRepository.class,
osRepository);
Line 77:
Line 78: final int osId = 0;
Line 79:
Line 80: Map<Integer, Map<Version, List<DisplayType>>> displayTypeMap =
new HashMap<Integer, Map<Version, List<DisplayType>>>();
new HashMap<> is enough thanks to jdk7. I sometimes forget that as well.
Line 81: displayTypeMap.put(osId, new HashMap<Version,
List<DisplayType>>());
Line 82: displayTypeMap.get(osId).put(null,
Arrays.asList(DisplayType.qxl));
Line 83:
when(osRepository.getDisplayTypes()).thenReturn(displayTypeMap);
Line 84: }
--
To view, visit http://gerrit.ovirt.org/18150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifff508fb2cbc3b2447f6fb7412d4feadd20a3c6e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
