Tal Nisan has posted comments on this change.
Change subject: engine: add checkstyle rule LeftCurly
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
Line 643: private DetailedLink decideWhichToDelete(DetailedLink link1,
DetailedLink link2) {
Line 644: String link1ParamType =
link1.getRequest().getBody().getType();
Line 645: String link2ParamType =
link2.getRequest().getBody().getType();
Line 646: //Verify for both links that body is not mandatory
Line 647: if ( (
This whole condition block should be rewritten
Line 648: (link1.getRequest().getBody().isRequired() != null)
Line 649: &&
Line 650: (link2.getRequest().getBody().isRequired() != null)
Line 651: )
--
To view, visit http://gerrit.ovirt.org/22962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04e86743352f4228eb5ad0ae7e9438f0089ba8f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
