Moti Asayag has posted comments on this change.
Change subject: core: [Fix] PCI limit in update VM template NIC
......................................................................
Patch Set 10:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
Line 76: if (!StringUtils.equals(oldIface.getName(),
getInterfaceName()) && !interfaceNameUnique(interfaces)) {
Line 77: return false;
Line 78: }
Line 79:
Line 80: if (getParameters().getInterface().getType() != null &&
what is the meaning of getParameters().getInterface().getType() != null ?
by looking at VmCommand.checkPciAndIdeLimit(), it seems if the type is null, it
is count as 1.
Line 81: !checkPciAndIdeLimit(oldIface,
Line 82: new ArrayList<VmNic>(interfaces),
Line 83: clusterCompatibilityVersion)) {
Line 84: return false;
--
To view, visit http://gerrit.ovirt.org/22515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I985e9adeefb00872542f7473f44fb25d44453f8a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
