Vojtech Szocs has posted comments on this change. Change subject: doc: Update README.developer regarding GWT debug ......................................................................
Patch Set 1: (1 comment) .................................................... File README.developer Line 182: Line 183: Debug port is 8000, detailed instructions for GWT debugging are at [1]. Line 184: Line 185: GWT debug URLs, provided components running on same machine: Line 186: WebAdmin http://127.0.0.1:8080/ovirt-engine/webadmin/WebAdmin.html?gwt.codesvr=127.0.0.1:9997 > I would have put static host page... something like default.html :) Hm, you mean a static file to be served instead of Java servlet mapped to WebAdmin.html? If you mean a static file, this wouldn't work I think, because our Java servlet for WebAdmin.html (used to serve GWT host page) uses JSP to embed dynamic data, for example user info, UI plugin info, etc. (Long time ago we had static host page, but we changed it to be dynamic.) > That is sort of like arguing about what if someone changes the servlet > mapping to not point to WebAdmin.html? vs what if someone changes the > welcome-file-list? Either one is possible and either one will break the > debugging suggested in this document. You are right, I agree with your point. I just feel that being explicit here is better, but it's just me. BTW, up to now, we typically used to reference GWT application explicitly - URL ending with .html suffix. The only exception to this (AFAIK) is welcome page [ovirt-engine.jsp], where the default content template [welcome_page.template] has URLs without .html suffix. @Alon/Alex - do you think we should use this convention (shorten URL, rely on welcome-file-list) also on other places? Also note that the URL should end with trailing slash (before the "?" query part, if it's present): /ovirt-engine/webadmin/?query Line 187: UserPortal http://127.0.0.1:8080/ovirt-engine/userportal/UserPortal.html?gwt.codesvr=127.0.0.1:9997 Line 188: Line 189: [1] http://wiki.ovirt.org/DebugFrontend Line 190: -- To view, visit http://gerrit.ovirt.org/23024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d8df4ea6fb8cc029d61d49fb4237ab6844d23a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
