Vitor de Lima has posted comments on this change.
Change subject: restapi: NPE on new VM
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1206:
Line 1207: <xs:complexType name="VirtIO_SCSI">
Line 1208: <xs:attribute name="enabled" type="xs:boolean" default="false"/>
Line 1209: </xs:complexType>
Line 1210:
This breaks the REST API because if you omit these entities, they receive null
as their value, which means that the UpdateVmCommand must preserve their
status. Defaulting them to false would always disable these devices when an
update is requested. I think the correct way to fix this is to put something
among the lines of:
if (parameters.isVirtioScsiEnabled() == null) {
parameters.setVirtioScsiEnabled(false);
}
In the constructor of AddVmCommand.
Line 1211: <xs:complexType name="SchedulingPolicyThresholds">
Line 1212: <xs:attribute name="low" type="xs:int">
Line 1213: <xs:annotation>
Line 1214: <xs:appinfo>
--
To view, visit http://gerrit.ovirt.org/22593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9cbc0634f2bb8a0c80efb40f1db4a0a904d2ac2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
